Enable hip-clang with cmake changes to link -lpthread and -lm #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszuppe
suggested changes
Aug 20, 2018
| @@ -56,6 +56,10 @@ foreach(test_src ${rocRAND_TEST_SRCS}) | |||
| foreach(amdgpu_target ${AMDGPU_TARGETS}) | |||
| target_link_libraries(${test_name} --amdgpu-target=${amdgpu_target}) | |||
| endforeach() | |||
| if(CMAKE_CXX_COMPILER MATCHES ".*/hipcc$") | |||
| # hip-clang needs specific flag to turn on pthread and m | |||
| target_link_libraries(${test_name} -lpthread -lm) | |||
There was a problem hiding this comment.
It should be target_link_libraries(${test_name} m). As for pthread:
set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
find_package(Threads REQUIRED)
should be in cmake/Dependencies.cmake (if it's needed only for tests then it should be in test dependencies section) and later target_link_libraries(${test_name} Threads::Threads). See https://cmake.org/cmake/help/latest/module/FindThreads.html
|
Fixed with HIP PR ROCm/HIP#637 |
|
The linked PR is not a fix but a work-around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help fix build issues for tests using hip-clang.